Bug 117050

Summary: Get rid of Javascript Exports file on Windows VS2010
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cmarcelo, commit-queue, ggaren, jonlee, morrita, oliver, ossy, roger_fong, sfalken
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch darin: review+

Roger Fong
Reported 2013-05-30 15:16:34 PDT
Use export macros instead. To do this, we need to turn WTF into a dll.
Attachments
patch (96.63 KB, patch)
2013-05-30 16:32 PDT, Roger Fong 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-05-30 16:32:24 PDT
Created attachment 203395 [details] patch
WebKit Commit Bot
Comment 2 2013-05-30 16:34:53 PDT
Attachment 203395 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.submit.sln', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorProduction.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/make-export-file-generator', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/jsc/jscCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/testapi/testapiCommon.props', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTFCommon.props', u'Source/WTF/wtf/DateMath.h', u'Source/WTF/wtf/ExportMacros.h', u'Source/WTF/wtf/FilePrintStream.h', u'Source/WTF/wtf/OSAllocator.h', u'Source/WTF/wtf/PageAllocationAligned.h', u'Source/WTF/wtf/Platform.h', u'Source/WTF/wtf/PrintStream.h', u'Source/WTF/wtf/StackBounds.h', u'Source/WTF/wtf/StringPrintStream.h', u'Source/WTF/wtf/ThreadSpecific.h', u'Source/WTF/wtf/WTFThreadData.h', u'Source/WTF/wtf/dtoa/cached-powers.h', u'Source/WTF/wtf/dtoa/double-conversion.h', u'Source/WTF/wtf/text/WTFString.h', u'Source/WTF/wtf/unicode/Collator.h', u'Source/WTF/wtf/unicode/UTF8.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.vcxproj/WebKit.sln', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props', u'Tools/DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props', u'Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props']" exit_code: 1 Source/WTF/wtf/OSAllocator.h:60: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/unicode/UTF8.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WTF/wtf/PageAllocationAligned.h:44: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/PageAllocationAligned.h:44: The parameter name "usage" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2013-05-30 16:35:31 PDT
Wow! That is totally awesome!
Roger Fong
Comment 4 2013-05-30 16:39:00 PDT
(In reply to comment #3) > Wow! That is totally awesome! Only for VS2010 tho :/ Hopefully when we get rid of VS2005 project files from the tree (soon!) then we actually won't have to worry about the exports file. :)
Roger Fong
Comment 5 2013-05-30 17:38:59 PDT
committed: http://trac.webkit.org/changeset/150995
Roger Fong
Comment 6 2013-05-30 17:40:08 PDT
<rdar://problem/13685861>
Csaba Osztrogonác
Comment 7 2013-05-31 02:25:15 PDT
(In reply to comment #5) > committed: http://trac.webkit.org/changeset/150995 FYI: It broke the build on the Apple Windows buildbots.
Roger Fong
Comment 8 2013-05-31 11:37:52 PDT
(In reply to comment #7) > (In reply to comment #5) > > committed: http://trac.webkit.org/changeset/150995 > > FYI: It broke the build on the Apple Windows buildbots. Yup because those are 2005, but not for long.
Patrick R. Gansterer
Comment 9 2013-10-31 01:35:30 PDT
*** Bug 76257 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.