Bug 136785

Summary:

Add JSCallee to program and eval CallFrames

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, fpizlo, ggaren, mark.lam, mmirman, oliver, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

136724

Attachments:

Description	Flags
Patch	mark.lam: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch with fixes for layout test failures	mark.lam: review+

Michael Saboff

Reported 2014-09-12 10:26:32 PDT

Currently the JSCallee slot for program and call eval CallFrames is left as null. These should be populated with a JSCallee in preparation for removing JSScope from the CallFrame.

Attachments
Patch (8.93 KB, patch) 2014-09-12 12:50 PDT, Michael Saboff	mark.lam: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (479.45 KB, application/zip) 2014-09-12 14:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (612.44 KB, application/zip) 2014-09-12 15:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (529.71 KB, application/zip) 2014-09-12 15:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (555.71 KB, application/zip) 2014-09-12 16:20 PDT, Build Bot	no flags	Details
Patch with fixes for layout test failures (11.73 KB, patch) 2014-09-12 17:15 PDT, Michael Saboff	mark.lam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2014-09-12 12:50:01 PDT

Created attachment 238047 [details] Patch

Mark Lam

Comment 2 2014-09-12 13:03:07 PDT

Comment on attachment 238047 [details] Patch r=me

Build Bot

Comment 3 2014-09-12 14:22:02 PDT

Comment on attachment 238047 [details] Patch Attachment 238047 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5706141589831680 New failing tests: fast/profiler/stop-then-function-call.html

Build Bot

Comment 4 2014-09-12 14:22:05 PDT

Created attachment 238059 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-09-12 15:00:18 PDT

Comment on attachment 238047 [details] Patch Attachment 238047 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6504123964850176 New failing tests: fast/profiler/stop-then-function-call.html

Build Bot

Comment 6 2014-09-12 15:00:23 PDT

Created attachment 238062 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-09-12 15:21:58 PDT

Comment on attachment 238047 [details] Patch Attachment 238047 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5442676484734976 New failing tests: fast/profiler/stop-then-function-call.html

Build Bot

Comment 8 2014-09-12 15:22:02 PDT

Created attachment 238065 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2014-09-12 16:20:17 PDT

Comment on attachment 238047 [details] Patch Attachment 238047 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6725690590232576 New failing tests: fast/profiler/stop-then-function-call.html

Build Bot

Comment 10 2014-09-12 16:20:21 PDT

Created attachment 238073 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Michael Saboff

Comment 11 2014-09-12 17:15:35 PDT

Created attachment 238078 [details] Patch with fixes for layout test failures

Mark Lam

Comment 12 2014-09-12 17:26:36 PDT

Comment on attachment 238078 [details] Patch with fixes for layout test failures r=me

Michael Saboff

Comment 13 2014-09-12 22:21:59 PDT

Committed r173600: <http://trac.webkit.org/changeset/173600>

Note You need to log in before you can comment on or make changes to this bug.