Bug 142653

Summary: Unreviewed EFL gardening. Update attachment-foo tests to failure.
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit EFLAssignee: Hunseop Jeong <hs85.jeong>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93353    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Hunseop Jeong
Reported 2015-03-12 22:46:45 PDT
Rebaseline the missing test results to failure. fast/attachment/attachment-select-on-click-inside-user-select-all.html fast/attachment/attachment-select-on-click.html Besides mark attachment-foo tests to failure because EFL didn't support the attachment feature.
Attachments
Patch (2.45 KB, patch)
2015-03-12 23:07 PDT, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Patch (2.48 KB, patch)
2015-03-16 22:21 PDT, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2015-03-20 02:01 PDT, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hunseop Jeong
Comment 1 2015-03-12 23:07:47 PDT
Created attachment 248570 [details] Patch
Hunseop Jeong
Comment 2 2015-03-16 22:21:41 PDT
Created attachment 248820 [details] Patch
WebKit Commit Bot
Comment 3 2015-03-20 01:54:52 PDT
Comment on attachment 248820 [details] Patch Rejecting attachment 248820 [details] from commit-queue. hs85.jeong@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Hunseop Jeong
Comment 4 2015-03-20 02:01:22 PDT
Created attachment 249098 [details] Patch
WebKit Commit Bot
Comment 5 2015-03-20 03:10:05 PDT
Comment on attachment 249098 [details] Patch Clearing flags on attachment: 249098 Committed r181797: <http://trac.webkit.org/changeset/181797>
WebKit Commit Bot
Comment 6 2015-03-20 03:10:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.