Bug 190799

Summary:

[ESNext][BigInt] Implement support for "**"

Product:

WebKit

Reporter:

Caio Lima <ticaiolima>

Component:

JavaScriptCore

Assignee:

Caio Lima <ticaiolima>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

179001

Attachments:

Description	Flags
WIP - Patch	none
WIP - Patch	none
Benchmarks	none
Patch	none
Patch	none
Benchmarks	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Caio Lima

Reported 2018-10-22 11:48:31 PDT

...

Attachments
WIP - Patch (43.94 KB, patch) 2019-01-07 11:05 PST, Caio Lima	no flags	Details Formatted Diff Diff
WIP - Patch (43.93 KB, patch) 2019-01-07 13:07 PST, Caio Lima	no flags	Details Formatted Diff Diff
Benchmarks (98.11 KB, text/plain) 2019-01-07 13:14 PST, Caio Lima	no flags	Details
Patch (43.97 KB, patch) 2019-01-24 16:52 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (43.99 KB, patch) 2019-01-25 04:08 PST, Caio Lima	no flags	Details Formatted Diff Diff
Benchmarks (97.02 KB, text/plain) 2019-01-25 04:32 PST, Caio Lima	no flags	Details
Patch (44.83 KB, patch) 2019-02-17 15:56 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (48.63 KB, patch) 2019-03-11 05:56 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Patch (48.58 KB, patch) 2019-05-06 06:34 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Patch (48.26 KB, patch) 2019-05-26 14:15 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Patch (48.23 KB, patch) 2019-05-27 13:34 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Patch (48.23 KB, patch) 2019-06-03 10:52 PDT, Caio Lima	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Caio Lima

Comment 1 2019-01-07 11:05:33 PST

Created attachment 358509 [details] WIP - Patch

Caio Lima

Comment 2 2019-01-07 13:07:31 PST

Created attachment 358518 [details] WIP - Patch

Caio Lima

Comment 3 2019-01-07 13:14:02 PST

Created attachment 358520 [details] Benchmarks This Patch is perf neutral in x86_64

Caio Lima

Comment 4 2019-01-24 16:52:34 PST

Created attachment 360053 [details] Patch

Caio Lima

Comment 5 2019-01-25 04:08:31 PST

Created attachment 360103 [details] Patch

Caio Lima

Comment 6 2019-01-25 04:32:06 PST

Created attachment 360105 [details] Benchmarks The patch is perf neutral.

Caio Lima

Comment 7 2019-02-17 15:56:14 PST

Created attachment 362260 [details] Patch

Caio Lima

Comment 8 2019-03-11 05:56:44 PDT

Created attachment 364248 [details] Patch

Caio Lima

Comment 9 2019-05-06 06:34:10 PDT

Created attachment 369121 [details] Patch

Saam Barati

Comment 10 2019-05-06 13:14:44 PDT

Comment on attachment 369121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369121&action=review LGTM overall. Some bugs I believe that are similar to ValueMod patch > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:862 > + if (childX && childY && childX.isNumber() && childY.isNumber()) { > + if (!node->isBinaryUseKind(BigIntUse)) > + didFoldClobberWorld(); > + setConstant(node, jsDoubleNumber(operationMathPow(childX.asNumber(), childY.asNumber()))); > + break; > + } same comment as I had in ValueMod patch. I believe you need to ensure that the types of X and Y are valid given BigInt. > Source/JavaScriptCore/dfg/DFGOperations.cpp:545 > + if (WTF::holds_alternative<JSBigInt*>(leftNumeric) || WTF::holds_alternative<JSBigInt*>(rightNumeric)) { > + if (WTF::holds_alternative<JSBigInt*>(leftNumeric) && WTF::holds_alternative<JSBigInt*>(rightNumeric)) > + RELEASE_AND_RETURN(scope, JSValue::encode(JSBigInt::exponentiate(exec, WTF::get<JSBigInt*>(leftNumeric), WTF::get<JSBigInt*>(rightNumeric)))); Not related to this patch, but maybe we can make this type of pattern easier to read since it's so common in all the operations. Maybe this can be a followup. But if we had something like: bool doBigIntMath(variant a, variant b, doMath lambda, throw lambda or throw message) It returns false if both are *not* BigInt. Returns true otherwise. Throws an exception if 1 of 2 are big int, otherwise, returns lambda

Caio Lima

Comment 11 2019-05-26 14:15:39 PDT

Created attachment 370657 [details] Patch

Caio Lima

Comment 12 2019-05-27 13:34:30 PDT

Created attachment 370705 [details] Patch

Saam Barati

Comment 13 2019-05-31 18:47:47 PDT

Comment on attachment 370705 [details] Patch r=me

Caio Lima

Comment 14 2019-06-03 10:52:38 PDT

Created attachment 371195 [details] Patch