Bug 217213

Summary:

Refactor WebGL implementation to use only GraphicsContextGL part 1

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

WebGL

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, koivisto, kondapallykalyan, luiz, noam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Mac

OS:

Unspecified

Bug Depends on:

217212, 217374

Bug Blocks:

217211, 217216

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	dino: review+
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-

Kimmo Kinnunen

Reported 2020-10-02 04:20:00 PDT

Refactor WebGL implementation to use only GraphicsContextGL Current implementation uses GraphicsContextGLOpenGL. This cannot support remote WebGL

Attachments
Patch (113.17 KB, patch) 2020-10-14 05:59 PDT, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (107.89 KB, patch) 2020-10-14 06:03 PDT, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (113.07 KB, patch) 2020-10-14 11:45 PDT, Kimmo Kinnunen	dino: review+	Details Formatted Diff Diff
Patch (196.16 KB, patch) 2020-10-15 05:48 PDT, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (112.55 KB, patch) 2020-10-15 23:50 PDT, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (306.14 KB, patch) 2020-10-16 04:18 PDT, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (196.16 KB, patch) 2020-10-16 04:25 PDT, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (196.16 KB, patch) 2020-10-16 04:28 PDT, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (196.18 KB, patch) 2020-10-16 04:37 PDT, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-10-02 04:20:42 PDT

<rdar://problem/69876105>

Kimmo Kinnunen

Comment 2 2020-10-14 05:59:45 PDT

Created attachment 411315 [details] Patch

Kimmo Kinnunen

Comment 3 2020-10-14 06:03:36 PDT

Created attachment 411317 [details] Patch

Kimmo Kinnunen

Comment 4 2020-10-14 11:45:31 PDT

Created attachment 411353 [details] Patch

Kimmo Kinnunen

Comment 5 2020-10-15 05:48:17 PDT

Created attachment 411433 [details] Patch

Dean Jackson

Comment 6 2020-10-15 15:50:21 PDT

Comment on attachment 411353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411353&action=review > Source/WebCore/ChangeLog:24 > + Introduce a virtual member fuction in GraphicsContextGL for typo function

Kimmo Kinnunen

Comment 7 2020-10-15 23:50:16 PDT

Created attachment 411539 [details] Patch

EWS

Comment 8 2020-10-16 01:18:32 PDT

kkinnunen@apple.com does not have reviewer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 411539 [details] from commit queue.

EWS

Comment 9 2020-10-16 03:56:05 PDT

Committed r268578: <https://trac.webkit.org/changeset/268578> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411539 [details].

Kimmo Kinnunen

Comment 10 2020-10-16 03:57:13 PDT

patches still left