Bug 229343

Summary: REGRESSION(r281305) [GStreamer] fast/mediastream/getDisplayMedia-frame-rate.html timeouts
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WPE WebKitAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, pnormand, sergio, tommyw, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=228941
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2021-08-20 11:41:39 PDT
The test fast/mediastream/getDisplayMedia-frame-rate.html started to timeout in GTK and WPE after r281305
Attachments
Patch (5.62 KB, patch)
2021-08-23 08:55 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (6.20 KB, patch)
2021-08-24 01:03 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2021-08-24 02:18 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2021-08-20 12:29:15 PDT
Expectations updated on r281329
Philippe Normand
Comment 2 2021-08-21 01:30:01 PDT
It was flaky before, so maybe this will be easier to fix now :) Will take a look soon.
Philippe Normand
Comment 3 2021-08-23 08:55:39 PDT
Created attachment 436199 [details] Patch
Philippe Normand
Comment 4 2021-08-23 08:56:13 PDT
Youenn r?
youenn fablet
Comment 5 2021-08-23 12:52:24 PDT
Comment on attachment 436199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436199&action=review > Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:76 > + m_source->removeVideoSampleObserver(*this); Might be good to stop observing when stopping as well. I would do like RealtimeVideoSource.
Philippe Normand
Comment 6 2021-08-24 01:03:25 PDT
Created attachment 436266 [details] Patch
EWS
Comment 7 2021-08-24 02:13:31 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Philippe Normand
Comment 8 2021-08-24 02:18:31 PDT
Created attachment 436270 [details] Patch
EWS
Comment 9 2021-08-24 03:07:51 PDT
Committed r281491 (240865@main): <https://commits.webkit.org/240865@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436270 [details].
Note You need to log in before you can comment on or make changes to this bug.