Bug 278731
| Summary: | [GTK][WebDriver] Update Selenium tests after fixing Selenium upstream WebKitGTK support code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bburg |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
276878@main / updated the imported selenium copy after some fixes Selenium upstream regarding WPE. Similar changes will be needed for WebKitGTK in Selenium itself.
For example, after updating `Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py::selenium_name()` to match the new lowercase scheme, running selenium tests with GTK results in:
./Tools/Scripts/run-webdriver-tests --release --gtk "imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::test_find_element_by_xpath"
```
...
ERROR ../../../../app/webkit/WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::test_find_element_by_xpath[webkitgtk] - AttributeError: module 'selenium.webdriver' has no attribute 'Webkitgtk'
...
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Ended up being fixed in 288959@main (bug283785)
*** This bug has been marked as a duplicate of bug 283785 ***
Lauro Moura
For the record, the selenium upstream fix was https://github.com/SeleniumHQ/selenium/pull/15046