Bug 51346

Summary: Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ddkilzer, dglazkov, eric, ossy, tony, tonyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2010-12-20 12:24:20 PST
Based on the feedback received at bug 51316. I'm not sure if most/all ports have interest in these build options, but perhaps worth considering.
Attachments
proposed patch (2.77 KB, patch)
2010-12-20 12:26 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-12-20 12:26:08 PST
Created attachment 77025 [details] proposed patch
Csaba Osztrogonác
Comment 2 2010-12-21 07:49:40 PST
ENABLE_TOUCH_EVENTS is enabled by default for Android and Chromium build. But it seems that Android doesn't use build-webkit script and Chromium ignores all --FEATURE and --no-FEATURE options passed to build-webkit. Eric, could you confirm or disprove it? Otherwise this patch looks good to me.
Eric Seidel (no email)
Comment 3 2010-12-21 10:45:30 PST
I know very little about Chromium's build, but that sounds right that they would ignore options passed to build-webkit.
Tony Chang
Comment 4 2011-01-04 10:35:01 PST
Yes, chromium ignores these flags to build-webkit. I think that's working as intended since flags can be modified in features.gypi.
Eric Seidel (no email)
Comment 5 2011-01-06 13:20:36 PST
Comment on attachment 77025 [details] proposed patch OK.
WebKit Commit Bot
Comment 6 2011-01-06 13:49:57 PST
Comment on attachment 77025 [details] proposed patch Clearing flags on attachment: 77025 Committed r75196: <http://trac.webkit.org/changeset/75196>
WebKit Commit Bot
Comment 7 2011-01-06 13:50:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.