Bug 241699

Summary: TextureMapper: nesting 3D rendering context support
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: cgarcia, magomez, mattwoodrow, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=113455
https://bugs.webkit.org/show_bug.cgi?id=281079
Bug Depends on: 244526    
Bug Blocks:    
Attachments:
Description Flags
test case
none
WIP patch none

Fujii Hironori
Reported 2022-06-16 13:56:54 PDT
Created attachment 460275 [details] test case TextureMapperGL: rendering glitch of a 3d transformed text in Strange-Loop-2012 hyper texts in the slides aren't painted as expected if they are :hover. https://github.com/BrendanEich/Strange-Loop-2012
Attachments
test case (29.12 KB, text/html)
2022-06-16 13:56 PDT, Fujii Hironori 		no flags
Details
WIP patch (25.01 KB, patch)
2022-10-16 18:45 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-06-16 18:30:26 PDT
Safari, Chrome, Firefox: Very smooth animation WebKitGTK, WinCairo WK1: not smooth animation WinCairo WK2: not smooth animation, text disappears
Fujii Hironori
Comment 2 2022-06-19 13:38:15 PDT
Disabling tet depth test makes the animation smooth. This seems to be a regression of my change (231816@main) enabling depth test. diff --git a/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp b/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp index f4d99408ff15..3890e1fa8c82 100644 --- a/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp +++ b/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp @@ -1043,7 +1043,6 @@ IntRect TextureMapperGL::clipBounds() void TextureMapperGL::beginPreserves3D() { - glEnable(GL_DEPTH_TEST); glClear(GL_DEPTH_BUFFER_BIT); }
Fujii Hironori
Comment 3 2022-06-19 14:20:28 PDT
In this test case, <section> and <span> elements has transform-style:preseve-3d, but intermediate <a> element doesn't have it. This is the case not supported as 231816@main change log explains. <section> transform-style:preseve-3d +<a> +<span> transform-style:preseve-3d +<span::after>
Radar WebKit Bug Importer
Comment 4 2022-06-23 13:57:11 PDT
<rdar://problem/95804784>
Fujii Hironori
Comment 5 2022-10-16 18:45:19 PDT
Created attachment 463018 [details] WIP patch
Matt Woodrow
Comment 6 2022-11-24 11:00:28 PST
In https://github.com/WebKit/WebKit/pull/6770 I'm adding 3 new TestExpectation annotations for this bug, for 3d tests that now pass on Mac/iOS, but still fail on GTK due to this bug (I think!).
Fujii Hironori
Comment 7 2024-10-29 03:04:42 PDT
*** This bug has been marked as a duplicate of bug 281079 ***
Note You need to log in before you can comment on or make changes to this bug.